Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change KTX_FEATURE_STATIC_LIBRARY to BUILD_SHARED_LIBS #953

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Change KTX_FEATURE_STATIC_LIBRARY to BUILD_SHARED_LIBS #953

wants to merge 1 commit into from
+22 −13

Conversation

UX3D-haertl
Copy link

@UX3D-haertl UX3D-haertl commented Oct 25, 2024 •
edited
Loading

This changes KTX_FEATURE_STATIC_LIBRARY to the inbuild cmake variable BUILD_SHARED_LIBS
Static builds are enforced for fmt and astc-encoder.
Both library use BUILD_SHARED_LIBS themself, so this fixes issues if KTX-Software is used as dependecy in other projects (which set BUILD_SHARED_LIBS)

Fixes #935

@CLAassistant
Copy link

CLAassistant commented Oct 25, 2024 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use BUILD_SHARED_LIBS instead of KTX_FEATURE_STATIC_LIBRARY
2 participants
@UX3D-haertl @CLAassistant